Updating vendored dependencies
LibreSign’s scoped PHP dependencies are maintained in the
LibreSign/3rdparty repository,
not by editing generated files inside the LibreSign application repository.
This is the maintainer procedure for updating the 3rdparty Git
submodule in LibreSign/libresign.
It applies to pull requests targeting main or a maintained stableXX
branch of the two code repositories. In those repositories stableXX
refers to the Nextcloud major. This differs from documentation branches such
as stable15, which refer to the LibreSign release major; see
Branch policies.
Automated update sequence
Use one source PR and one destination PR for the same target branch.
In LibreSign/3rdparty pull requests, review the Dependabot version change,
composer.lockand the intended target branch. Do not merge yet.As a maintainer with write permission, post this entire comment on the open 3rdparty PR:
/composer-update
The bot regenerates scoped vendor files and, when needed, commits them to the source PR with a GitHub-verified signature and DCO sign-off. An acknowledgement (eyes reaction and a status comment with the Actions link) is attempted; the status comment is updated with the result. A thumbs-up means regeneration finished, not that review or CI passed. If the command fails, inspect the linked Actions logs before retrying.
Wait for the new source HEAD’s checks to complete, especially
Check vendor changes, PHP lint and DCO. Confirm there are no failures, missing mandatory checks or unexpected changes to generated files.Comment on that same 3rdparty PR:
/libresign-pr
The automation checks the source PR and creates a corresponding PR in LibreSign, targeting the matching branch and initially pointing its
3rdpartygitlink to the proposed source HEAD. Inspect the created PR, changed files and CI. It is not ready for its final merge yet.Once the 3rdparty PR is approved, merge the 3rdparty PR first. Record the actual merged SHA from that repository, not the Dependabot head SHA.
On the linked LibreSign PR, comment:
/update-3rdparty
The bot updates the
3rdpartygitlink to the merged source SHA with a new, signed and DCO-compliant commit. Verify that the gitlink actually matches the merged SHA and that the updated LibreSign CI runs against the new HEAD.After all relevant LibreSign checks and reviews pass, merge the LibreSign PR. Verify the branch’s final
3rdpartygitlink matches the intended 3rdparty merged commit.
The commands do not merge PRs. They operate on same-repository PR branches for authorized maintainers; forks are excluded. Do not copy unreviewed changes across repositories or assume that a green source check proves LibreSign’s signing and certificate integration is safe. Follow Testing for the affected test matrix.
When the source PR was merged early
Once the merged-source-safe workflow is active in LibreSign/3rdparty, a
maintainer may post /libresign-pr on an already merged source PR.
The workflow resolves the actual source merge commit SHA, rather than
depending on the source branch still existing, and generates the Composer
diff relative to the merge’s first parent.
This route accepts a two-parent merge commit, verifies that the target
3rdparty gitlink would advance rather than move backward or sideways,
and creates a matching LibreSign PR referencing the merged SHA directly.
Do not run /update-3rdparty again for that same SHA. Review the source
merge commit’s signature and matching DCO sign-off separately: green
checks on the source PR head do not prove the merge commit is compliant.
The destination LibreSign PR must pass its own CI and normal review.
If a destination branch or PR already exists, inspect and continue it
instead of creating a duplicate. If this automation is unavailable or
rejects the source (for example, it was squash-merged rather than merged
with two parents), follow the manual update instructions below: create a
separate, narrowly scoped LibreSign PR targeting the corresponding
code branch and update only the 3rdparty gitlink to the source merge
SHA. Create a new verified signed/DCO commit, verify LibreSign CI, and do
not reconstruct the source PR, amend reviewed commits or force-push.
Merge commit signatures and DCO
A successful DCO check on a PR validates the submitted commits, not
a separate merge commit created later by GitHub. A green Verified badge
on a merge commit likewise does not prove the DCO sign-off is present.
When using a GitHub merge method that creates a merge commit, ensure its
message includes a Signed-off-by: Name <email> trailer matching the
effective merge-commit author. Confirm the author’s actual name and
email instead of assuming they equal the local Git configuration or bot
identity. Preserve the reviewed, individually signed commits.
After merging each repository PR, inspect the actual merge SHA for a verified cryptographic signature and a DCO trailer matching its author. If these are missing, stop using the defective merge procedure and correct it for future merges. Do not rewrite protected history to repair already published merges. For general requirements, see Commits.
Troubleshooting
No acknowledgement: Inspect the issue-comment Actions run on the source repository. The reaction API may fail even when the visible status comment works; check the workflow log.
Regeneration failed: Inspect the first failing Composer or commit verification step. Do not merge without a regenerated, reviewed source HEAD. Never disable signature or DCO checks to make an update pass.
Source HEAD changed after CI: Wait for new checks and issue the subsequent command only after confirming the revised commit.
Destination branch or PR already exists: Inspect and continue that PR rather than creating a duplicate or overwriting its branch.
Source PR already merged: Use
/libresign-prif the merged-source workflow is available; otherwise follow the manual gitlink procedure.Destination checks fail: Diagnose the LibreSign integration independently of the successful 3rdparty Composer checks.
The current workflow definitions live in the code repositories. This page is the single maintainer-facing source for their cross-repository sequence; repository READMEs and contribution guides should link here rather than repeat the procedure.